<html>
<head><meta charset="utf-8"><title>rustfmt in 1.45.0 · t-release · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/index.html">t-release</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/rustfmt.20in.201.2E45.2E0.html">rustfmt in 1.45.0</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="204163479"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/rustfmt%20in%201.45.0/near/204163479" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Daniel Smith <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/rustfmt.20in.201.2E45.2E0.html#204163479">(Jul 17 2020 at 01:41)</a>:</h4>
<p>Hi, I made a comment on <a href="https://github.com/rust-lang/rust/issues/73078">https://github.com/rust-lang/rust/issues/73078</a>, but I'm not sure if comments on closed issues are seen. Some auto-generated files with <code>![cfg_attr(rustfmt, rustfmt_skip)]</code> are getting formatted by rustfmt after upgrading to 1.45.0. As far as I can tell from the release notes, that was not intentional. Is there something I'm missing?</p>



<a name="204163865"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/rustfmt%20in%201.45.0/near/204163865" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Lokathor <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/rustfmt.20in.201.2E45.2E0.html#204163865">(Jul 17 2020 at 01:51)</a>:</h4>
<p>I cannot fix your problem with rustfmt but I can tell you that comments on closed issues are seen by anyone subscribed to the issue. By default it doesn't un-subscribe people when the issue closes, so basically all the same people will see your comment.</p>



<a name="204165719"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/rustfmt%20in%201.45.0/near/204165719" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/rustfmt.20in.201.2E45.2E0.html#204165719">(Jul 17 2020 at 02:38)</a>:</h4>
<p>I would file a new issue regardless, perhaps on the rustfmt repo. Maybe we missed a beta backport or something?</p>



<a name="204210982"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/rustfmt%20in%201.45.0/near/204210982" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Daniel Smith <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/rustfmt.20in.201.2E45.2E0.html#204210982">(Jul 17 2020 at 14:17)</a>:</h4>
<p>Will do. thanks!</p>



<a name="204229493"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/rustfmt%20in%201.45.0/near/204229493" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> cuviper <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/rustfmt.20in.201.2E45.2E0.html#204229493">(Jul 17 2020 at 16:41)</a>:</h4>
<p>did we miss one of the 1.44.1 fixes?</p>



<a name="204230269"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/rustfmt%20in%201.45.0/near/204230269" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/rustfmt.20in.201.2E45.2E0.html#204230269">(Jul 17 2020 at 16:49)</a>:</h4>
<p>that's my theory yeah</p>



<a name="204230302"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/rustfmt%20in%201.45.0/near/204230302" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Notification Bot <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/rustfmt.20in.201.2E45.2E0.html#204230302">(Jul 17 2020 at 16:49)</a>:</h4>
<p>This topic was moved here from <a class="stream-topic" data-stream-id="122651" href="/#narrow/stream/122651-general/topic/rustfmt.20in.201.2E45.2E0">#general &gt; rustfmt in 1.45.0</a> by <span class="user-mention silent" data-user-id="116122">simulacrum</span></p>



<a name="204230303"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/rustfmt%20in%201.45.0/near/204230303" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Notification Bot <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/rustfmt.20in.201.2E45.2E0.html#204230303">(Jul 17 2020 at 16:49)</a>:</h4>
<p>This topic was moved by <span class="user-mention silent" data-user-id="116122">simulacrum</span> to <a class="stream-topic" data-stream-id="241545" href="/#narrow/stream/241545-t-release/topic/rustfmt.20in.201.2E45.2E0">#t-release &gt; rustfmt in 1.45.0</a></p>



<a name="204230304"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/rustfmt%20in%201.45.0/near/204230304" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Notification Bot <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/rustfmt.20in.201.2E45.2E0.html#204230304">(Jul 17 2020 at 16:49)</a>:</h4>
<p>This topic was moved here from <a class="stream-topic" data-stream-id="122651" href="/#narrow/stream/122651-general/topic/rustfmt.20in.201.2E45.2E0">#general &gt; rustfmt in 1.45.0</a> by <span class="user-mention silent" data-user-id="116122">simulacrum</span></p>



<a name="204230371"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/rustfmt%20in%201.45.0/near/204230371" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/rustfmt.20in.201.2E45.2E0.html#204230371">(Jul 17 2020 at 16:50)</a>:</h4>
<p>uh, maybe a bit excessive there bot</p>



<a name="204266945"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/rustfmt%20in%201.45.0/near/204266945" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Daniel Smith <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/rustfmt.20in.201.2E45.2E0.html#204266945">(Jul 17 2020 at 22:29)</a>:</h4>
<p>For reference, I filed <a href="https://github.com/rust-lang/rust/issues/74443">https://github.com/rust-lang/rust/issues/74443</a>. Thanks for looking into this!</p>



<a name="204306115"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/rustfmt%20in%201.45.0/near/204306115" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Yuki Okushi <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/rustfmt.20in.201.2E45.2E0.html#204306115">(Jul 18 2020 at 16:05)</a>:</h4>
<p>yep 1.45.0 uses <code>rustfmt 1.4.15-stable</code>, not <code>1.4.16</code> actually :/</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>